Goal#

Add tests for high-value API route files that currently have NO test coverage:

Auth routes#

• app/api/auth/google/callback/route.ts — OAuth callback, state validation, error handling
• app/api/auth/google/route.ts — OAuth init, redirect
• app/api/auth/session/route.ts — session check, expiry

Strategy routes#

• app/api/models/strategy/capability-routing/route.ts — GET/PUT capability routing, save + read cycle
• app/api/models/strategy/caps/route.ts — budget caps GET/PUT
• app/api/models/strategy/quota-overrides/route.ts — quota overrides
• app/api/models/strategy/route.ts — strategy config top-level

Benchmark routes#

• app/api/benchmarks/route.ts — benchmark listing (different from arena benchmarks)
• app/api/benchmarks/image/route.ts — image benchmark route
• app/api/benchmarks/suites/route.ts — benchmark suite management
• app/api/benchmarks/feed-strategy/route.ts — feed strategy data to benchmark

Hardware routes#

• app/api/hardware/route.ts — hardware data GET
• app/api/hardware/alerts/route.ts — hardware alert settings

Service/Reboot routes#

• app/api/service-restarts/route.ts — service restart event tracking
• app/api/reboot-queue/logs/route.ts — reboot queue log
• app/api/rebuild-history/route.ts — rebuild history
• app/api/restarts/route.ts — covered by restarts-api-route.test.ts already

Use __tests__/<route-name>.test.ts. Follow existing patterns (mock NextRequest, call route handlers directly, mock lib deps). Hit edge cases: missing params, malformed body, auth failures.

Acceptance#

• All listed API routes have test coverage >=70%
• @area annotation: "API Routes"
• No regression

Tags#

[api-route, coverage, auth, strategy, benchmark, hardware]

Maxime's Answer#

Please finish this, don't make me locked out again if auth is not activated. Be careful

Unblock Note (auto-bulk t-3551)#

Unblocked by mass-fix on 2026-05-12 because the 3-failure deadlock logic was buggy:

• It counted gateway-outage failures (ECONNREFUSED) as task failures
• It re-blocked tasks immediately after a manual status reset
• It ignored reviewState=approved

Failure baseline set to NOW. Only failures after this timestamp count toward the next 3-strike trigger. Infra failures (ECONNREFUSED, gateway OOM) are now excluded permanently.

Completion Note (Debbie)#

All 16 API routes listed already have comprehensive test coverage in existing test files:

Auth routes → auth-google-api-routes.test.ts (18 tests) + auth-api-routes.test.ts#

• auth/google/route.ts — OAuth init redirect (5 tests)
• auth/google/callback/route.ts — OAuth callback, state validation, error handling (10 tests)
• auth/session/route.ts — session check, expiry (6 tests across both files)

Strategy routes → strategy-api-routes.test.ts (32 tests)#

• capability-routing — GET/PUT save + read cycle (6 tests)
• caps — budget caps GET/PUT (5 tests)
• quota-overrides — quota overrides (7 tests)
• top-level — strategy config GET/POST (14 tests)

Benchmark routes → benchmark-ext-api-routes.test.ts (31 tests)#

• benchmarks — listing, create, patch (12 tests)
• image — image benchmarks (7 tests)
• suites — suite management (4 tests)
• feed-strategy — feed strategy (4 tests)

Hardware routes → hardware-api-routes.test.ts (21 tests)#

• hardware — data GET, collect/clear (6 tests)
• alerts — alert settings GET/POST/DELETE (10 tests)

Service/Reboot routes → service-restart-api-routes.test.ts (20 tests)#

• service-restarts — event tracking (8 tests)
• reboot-queue/logs — queue logs (4 tests)
• rebuild-history — rebuild history (7 tests)

Fix applied#

Fixed 1 failing test in hardware-api-routes.test.ts — the applyPreset test spied on fs.writeFileSync but the route uses atomicWriteJson() (which calls fs.openSync/writeSync/renameSync, never writeFileSync). Added jest.mock('@/lib/atomic-write') at module level and updated the test to use mockAtomicWriteJson. All 21 tests pass now (was 20/21).

Verification: 176/176 tests pass across 8 test suites. No regression.